Re: WARNING: CPU: 1 PID: 813 at kernel/module.c:291 module_assert_mutex_or_preempt+0x49/0x90()

[Rusty Russell]

poma <pomidorabelisima@xxxxxxxxx> writes:
>> Ref.
>> https://bugzilla.redhat.com/show_bug.cgi?id=1252167
>> https://bugzilla.kernel.org/show_bug.cgi?id=102631
>> 
>
> You guys are really something.

Hi Poma,

        I understand your frustration!

I got involved via the other thread which didn't mention your bug report
anywhere.  I'm sure Laura was trying to be helpful by creating a minimal
report, but the resulting patch erred in not crediting you.

> First of all, as is evident here, I am the original reporter, not Laura Abbott <labbott@xxxxxxxxxx>.

Thanks for clarifying that.  I have fixed the commit message to credit
you.  See below.

> -All- your comments including the final patch on this issue, are just plain wrong.[1]
> 
> This patch only hides the actual problem with this particular device - the dual tuner combination driven by dvb_usb_af9015 & mxl5007t, broken by design since day one.

Oh, there's definitely a real issue in the driver; this one is cosmetic.

> Read the entire https://bugzilla.redhat.com/show_bug.cgi?id=1252167
> and stop this nonsense.
>
> NACK "module: Fix locking in symbol_put_addr()"

Yeah, I've had days like this, too :(

Anyway, thanks for finding this bug: if the driver init hadn't been
screwed it wouldn't have taken that path and found this for us.

Good luck with the other issue!
Rusty.