Re: [PATCH 03/11] ocfs2: Less checks in ocfs2_rename() after error detection

From: SF Markus Elfring
Date: Tue Sep 01 2015 - 03:42:53 EST


>> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
>> Date: Sat, 4 Jul 2015 15:30:18 +0200
>>
>> Skip checks for a few variables in three error handling cases within
>> the ocfs2_rename() function by adjustment of a few jump targets
>> according to the Linux coding style convention.
>>
>> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
>
> I don't think this is an improvement.

How do you think about the other update suggestions from this patch series?

Would anybody like to contribute constructive comments so that further progress
can eventually be achieved for a corresponding source code review?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/