RE: [PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions
From: 平松雅巳 / HIRAMATU，MASAMI
Date: Tue Sep 01 2015 - 07:38:49 EST
> From: Ingo Molnar [mailto:mingo.kernel.org@xxxxxxxxx] On Behalf Of Ingo Molnar
> * Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:
> > Hi
> > perf tools has a copy of the x86 instruction decoder for decoding
> > Intel PT. [...]
> So that's the arch/x86/lib/insn.c instruction length decoder that the kernel uses
> for kprobes et al - and the two versions already forked slightly:
> -#include "inat.h"
> -#include "insn.h"
> +#include <asm/inat.h>
> +#include <asm/insn.h>
> it would be nice to add a diff check to the perf build, and (non-fatally) warn
> during the build if the two versions depart from each other?
> This will make sure the two versions are fully in sync in the long run as well.
> ( Alternatively we could perhaps also librarize it into tools/lib/, and teach the
> kernel build to pick that one up? )
Agreed, what I concern is that someone finds a bug and fixes one of them and
another is not fixed.
I'll see the forked version and check if it can be merged into the kernel.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/