Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios
From: Rob Herring
Date: Tue Sep 01 2015 - 07:55:08 EST
On Tue, Sep 1, 2015 at 3:32 AM, Javier Martinez Canillas
> Hello Peter,
> On Fri, Aug 28, 2015 at 7:52 PM, Peter Griffin <peter.griffin@xxxxxxxxxx> wrote:
>> gpio.txt documents that GPIO properties should be named
>> "[<name>-]gpios", with <name> being the purpose of this
>> GPIO for the device.
>> This change has been done as one atomic commit.
>> Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
>> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
>> Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt | 6 +++---
>> arch/arm/boot/dts/stihxxx-b2120.dtsi | 4 ++--
>> drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 +-
>> 3 files changed, 6 insertions(+), 6 deletions(-)
>> diff --git a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
>> index d4def76..e70d840 100644
>> --- a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
>> +++ b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
>> @@ -35,7 +35,7 @@ Required properties (tsin (child) node):
>> - tsin-num : tsin id of the InputBlock (must be between 0 to 6)
>> - i2c-bus : phandle to the I2C bus DT node which the demodulators & tuners on this tsin channel are connected.
>> -- rst-gpio : reset gpio for this tsin channel.
>> +- reset-gpios : reset gpio for this tsin channel.
> The documentation is a bit outdated, the GPIO subsystem supports both
> -gpio and -gpios, see commit:
> dd34c37aa3e8 ("gpio: of: Allow -gpio suffix for property names")
Yes, because we have lots of them.
> So it makes sense to me to use -gpio instead of -gpios in this case
> since is a single GPIO. Also rst is already a descriptive name since
> that's how many datasheets name a reset pin. I'm not saying I'm
> against this patch, just pointing out since the commit message is a
> bit misleading.
I believe that this has been discussed at length and it was decided
that new bindings should use "-gpios" even for 1. Just like "clocks"
is always plural.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/