Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator
From: Tony Lindgren
Date: Tue Sep 01 2015 - 14:56:16 EST
* Mark Brown <broonie@xxxxxxxxxx> [150901 11:40]:
> On Tue, Sep 01, 2015 at 07:17:21AM -0700, Tony Lindgren wrote:
> > Why don't you just make reg unused for pbias_regulator since
> > we already use regmap for this driver?
> > Then in the pbias driver just define the register offset from
> > the syscon base? You may need to set it based on the compatible
> > value, but it's not like it's going to change for SoC.
> > If we eventually add some API to calculate reg base offset
> > from the syscon base it's easy to update the driver to use
> > that.
> That'd work. The other thing I was thinking we could do is to get
> syscon to treat any excessively large address that gets passed in that
> looks like an absolute address appropriately.
Hmm wouldn't that get messy for 64-bit :) How about something
unsigned long syscon_regmap_get_offset(struct regmap *syscon,
void __iomem *base)
Not sure if that's something that some drivers would start to
misuse with read/writel though.. Presumably not if the driver
already is using syscon.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/