Re: [PATCH V7 1/3] genalloc:support memory-allocation with bytes-alignment to genalloc

From: Scott Wood
Date: Tue Sep 01 2015 - 20:30:32 EST

On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote:
> Bytes alignment is required to manage some special RAM,
> so add gen_pool_first_fit_align to genalloc,
> meanwhile add gen_pool_alloc_data to pass data to
> gen_pool_first_fit_align(modify gen_pool_alloc as a wrapper)
> Signed-off-by: Zhao Qiang <qiang.zhao@xxxxxxxxxxxxx>
> ---
> Changes for v6:
> - patches set v6 include a new patch because of using
> - genalloc to manage QE MURAM, patch 0001 is the new
> - patch, adding bytes alignment for allocation for use.
> Changes for v7:
> - cpm muram also need to use genalloc to manage, it has
> a function to reserve a specific region of muram,
> add offset to genpool_data for start addr to be allocated.

This seems to be describing more than just the changes in this patch. What
does also handling cpm have to do with this patch? Are you adding support
for reserving a specific region in this patch? I don't see it, and in any
case it should go in a different patch.

> +/*
> + * gen_pool data descriptor for gen_pool_first_fit_align.
> + */
> +struct genpool_data_align {
> + int align; /* alignment by bytes for starting address */
> + unsigned long offset; /* the offset of allocation start addr*/
> +};

The offset belongs on the caller side, not here.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at