[PATCH 3.13.y-ckt 31/60] bridge: mdb: fix double add notification

From: Kamal Mostafa
Date: Tue Sep 01 2015 - 21:08:33 EST

3.13.11-ckt26 -stable review patch. If anyone has any objections, please let me know.


From: Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx>

commit 5ebc784625ea68a9570d1f70557e7932988cd1b4 upstream.

Since the mdb add/del code was introduced there have been 2 br_mdb_notify
calls when doing br_mdb_add() resulting in 2 notifications on each add.

Command: bridge mdb add dev br0 port eth1 grp permanent
Before patch:
root@debian:~# bridge monitor all
[MDB]dev br0 port eth1 grp permanent
[MDB]dev br0 port eth1 grp permanent

After patch:
root@debian:~# bridge monitor all
[MDB]dev br0 port eth1 grp permanent

Signed-off-by: Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx>
Fixes: cfd567543590 ("bridge: add support of adding and deleting mdb entries")
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Kamal Mostafa <kamal@xxxxxxxxxxxxx>
net/bridge/br_mdb.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c
index af8315a..589afd0 100644
--- a/net/bridge/br_mdb.c
+++ b/net/bridge/br_mdb.c
@@ -350,7 +350,6 @@ static int br_mdb_add_group(struct net_bridge *br, struct net_bridge_port *port,
if (state == MDB_TEMPORARY)
mod_timer(&p->timer, now + br->multicast_membership_interval);

- br_mdb_notify(br->dev, port, group, RTM_NEWMDB);
return 0;


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/