Re: [PATCH v4] pinctrl: mediatek: Implement wake handler and suspend resume

From: Daniel Kurtz
Date: Wed Sep 02 2015 - 02:03:10 EST

Hi maoguang,

On Tue, Aug 25, 2015 at 12:27 AM, Sudeep Holla <sudeep.holla@xxxxxxx> wrote:
> On 14/08/15 09:38, maoguang.meng@xxxxxxxxxxxx wrote:
>> From: Maoguang Meng <maoguang.meng@xxxxxxxxxxxx>
>> This patch implement irq_set_wake to get who is wakeup source and
>> setup on suspend resume.
>> Signed-off-by: Maoguang Meng <maoguang.meng@xxxxxxxxxxxx>

Can you please respond to Sudeep's questions:

> Does this pinmux controller:
> 1. Support wake-up configuration ? If not, you need to use
> IRQCHIP_SKIP_SET_WAKE. I don't see any value in writing the
> mask_{set,clear} if the same registers are used for {en,dis}able
> 2. Is in always on domain ? If not, you need save/restore only to
> resume back the functionality. Generally we can set
> IRQCHIP_MASK_ON_SUSPEND to ensure non-wake-up interrupts are
> disabled during suspend and re-enabled in resume path. You just
> save/restore raw values without tracking the wake-up source.
> Also I see that no care is taken to set the port irq as wake enable
> source. It may work with current mainline, but won't with -next. Please
> ensure the port irq to the parent interrupt controller remains
> enabled(i.e set as wake).

> Regards,
> Sudeep
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at