Re: [PATCH 4/4] [resend #2] tridentfb: Add DDC support

From: Tomi Valkeinen
Date: Wed Sep 02 2015 - 07:30:25 EST


Hi,

On 24/08/15 22:37, Ondrej Zary wrote:
> Add DDC support for Trident cards.
>
> Tested on TGUI9440, TGUI9680, 3DImage 9750, Blade3D 9880 and Blade XP.
>
> Signed-off-by: Ondrej Zary <linux@xxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/video/fbdev/Kconfig | 9 ++
> drivers/video/fbdev/tridentfb.c | 192 ++++++++++++++++++++++++++++++++++++++-
> 2 files changed, 196 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 2d98de5..e2531b8 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1680,6 +1680,15 @@ config FB_TRIDENT
> To compile this driver as a module, choose M here: the
> module will be called tridentfb.
>
> +config FB_TRIDENT_DDC
> + bool "DDC for Trident support"
> + depends on FB_TRIDENT
> + select FB_DDC
> + select FB_MODE_HELPERS
> + default y
> + help
> + Say Y here if you want DDC support for your Trident graphics card.
> +

Why would somebody not want this enabled? Is there some drawback if it's
enabled?

Tomi

Attachment: signature.asc
Description: OpenPGP digital signature