Re: [PATCH 1/2] mmc: sdhci-pxav3: Fix tabbing issue

From: Vaibhav Hiremath
Date: Wed Sep 02 2015 - 08:25:27 EST

On Wednesday 02 September 2015 02:01 AM, Joe Perches wrote:
On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
There were some coding style issues where spaces have been used instead
of tabs, for example, in macro definitions, alignment of function
declarations/definitions, etc...

This patch fixes all such occurrences in the code.
And also use BIT for bit definitions.

Please send 2 patches instead.

diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
@@ -128,7 +133,7 @@ static int mv_conf_mbus_windows(struct platform_device *pdev,

static int armada_38x_quirks(struct platform_device *pdev,
- struct sdhci_host *host)
+ struct sdhci_host *host)

This is not an improvement.

Missed to highlight one more point here,

The kernel CodingStyle talks about indentation, pasting it below -

Outside of comments, documentation and except in Kconfig, spaces are
never used for indentation.

But I see spaces are being used at lot of places :)

Till now all the patches or drivers which I submitted, I never used
spaces. :)
Anyway, just wanted to highlight CodingStyle document here.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at