Re: [PATCH 01/15] perf tools: Fix parse_events_add_pmu caller

[Jiri Olsa]

On Wed, Sep 02, 2015 at 10:00:53AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Sep 02, 2015 at 09:56:31AM +0200, Jiri Olsa escreveu:
> > Following commit changed parse_events_add_pmu interface:
> >   36adec85a86f perf tools: Change parse_events_add_pmu interface
> > 
> > but forgot to change one caller. Because of lessen compilation
> > rules for the bison parser, the compiler did not warn on that.
> 
> Humm, wonder what can be done to improve this situation...  No ideas?

not really.. :-\ it's generated code, that will fail to compile
or spit other loads of warnings if we enable them

moving most of the code out of parse-event.y to other objects helps,
but thats pretty much what we do now

> 
> Applying to perf/urgent,

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/