Re: perf: possible bug in perf_event__read_size

From: Vince Weaver
Date: Wed Sep 02 2015 - 11:33:21 EST


On Wed, 2 Sep 2015, Vince Weaver wrote:
> Shouldn't that be
>
> if (event->attr.read_format & PERF_FORMAT_ID)
> size += sizeof(u64);

never mind, after a lot of further thought I can see this is a "clever"
hack to allow group events to have an ID for each value.

It's a shame the perf_event code doesn't more comments in the code,
especially when the code is being clever like this.

Vince
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/