Re: [PATCH] ARM: dts: Add ddc i2c reference to veyron

From: Rob Herring
Date: Wed Sep 02 2015 - 20:13:49 EST

On Wed, Sep 2, 2015 at 4:25 PM, Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:
> The ddc-i2c-bus property was missing from the veyron dtsi file since
> downstream the ddc-i2c-bus was still being specified in rk3288.dtsi and
> nobody noticed when the veyron dtsi was sent upstream. Add it.
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> ---
> Note: I noticed that this was wrong but I don't currently have
> graphics up and running on upstream on veyron. Posting this anyway
> since it's pretty clear that it's needed. If someone else wants to
> try it out that'd be nice, otherwise I'll put it on my list to figure
> out how to get myself setup for graphics upstream. ;)

Based on your other patch, this is temporary, right?

I've been looking at DRM a lot lately. I think specifying the i2c bus
in the hdmi chip or IP block node is wrong. If the I2C host is
separate from the HDMI block, then it's only connection is to the HDMI
connector. So the I2C host to the connector relationship is what the
DT should describe. HPD gpio is similar. Now if the HDMI bridge
controls DDC and HPD directly, then we don't need to describe those


> arch/arm/boot/dts/rk3288-veyron.dtsi | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
> index 2fa7a0d..275c78c 100644
> --- a/arch/arm/boot/dts/rk3288-veyron.dtsi
> +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
> @@ -158,6 +158,7 @@
> };
> &hdmi {
> + ddc-i2c-bus = <&i2c5>;
> status = "okay";
> };
> --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at