Re: [PATCH v6 2/3] KVM: dynamic halt_poll_ns adjustment
From: Wanpeng Li
Date: Thu Sep 03 2015 - 04:53:02 EST
On 9/3/15 3:31 PM, Paolo Bonzini wrote:
On 02/09/2015 21:23, David Matlack wrote:
I actually wasn't thinking about vcpu->halt_poll_ns though. If
That's definitely a bug, yes.
single_task_running() breaks us out of the loop we will "goto out" instead
of scheduling. My suspicion is this will cause us to loop calling
kvm_vcpu_block and starve the waiting task (at least until need_resched()),
which would break the "only hog the cpu when idle" aspect of halt-polling.
Ok, I will send out v7 to fix this in this sunday since there is
vacation in my country currently.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/