Re: [PATCH] crypto/testmgr: don't copy from source IV too much

From: Herbert Xu
Date: Thu Sep 03 2015 - 09:21:12 EST

On Thu, Sep 03, 2015 at 02:32:00PM +0300, Andrey Ryabinin wrote:
> While the destination buffer 'iv' is MAX_IVLEN size,
> the source 'template[i].iv' could be smaller. Thus
> copying it via memcpy() leads to invalid memory access.
> Use strlcpy() instead.
> Signed-off-by: Andrey Ryabinin <aryabinin@xxxxxxxx>

Thanks for the patch. Unfortunately it's broken because the IV
is not a string and can contain NULs. So either fix it by using
the real ivsize, or change template[i].iv to a char array.

Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page:
PGP Key:
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at