[PATCH v2 3/5] drivers/misc/sgi-gru: remove always false condition

From: Sudip Mukherjee
Date: Thu Sep 03 2015 - 10:51:13 EST


The member gid in struct gru_dump_chiplet_state_req is unsigned int. So
it can never be less than 0.

Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
Acked-by: Dimitri Sivanich <sivanich@xxxxxxx>
---

v2: no change, sent as a part of the series.

drivers/misc/sgi-gru/grukdump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru/grukdump.c
index 7e9aae5..313da31 100644
--- a/drivers/misc/sgi-gru/grukdump.c
+++ b/drivers/misc/sgi-gru/grukdump.c
@@ -194,7 +194,7 @@ int gru_dump_chiplet_request(unsigned long arg)
return -EFAULT;

/* Currently, only dump by gid is implemented */
- if (req.gid >= gru_max_gids || req.gid < 0)
+ if (req.gid >= gru_max_gids)
return -EINVAL;

gru = GID_TO_GRU(req.gid);
--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/