Re: [PATCH v2 6/6] input: mms114: Fix module autoload for OF platform driver

From: Dmitry Torokhov
Date: Thu Sep 03 2015 - 13:54:23 EST


On Sat, Aug 29, 2015 at 12:50:55PM +0200, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luis@xxxxxxxxxxxxxxxxx>

Already have this one as well.

> ---
>
> Moving the MODULE_DEVICE_TABLE into the CONFIG_OF #ifdef block.
> As suggested by Dmitry Torokhov.
>
> Thanks for the review Dmitry,
> Luis
>
> drivers/input/touchscreen/mms114.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c
> index 67c0d31..df778f4 100644
> --- a/drivers/input/touchscreen/mms114.c
> +++ b/drivers/input/touchscreen/mms114.c
> @@ -572,6 +572,7 @@ static const struct of_device_id mms114_dt_match[] = {
> { .compatible = "melfas,mms114" },
> { }
> };
> +MODULE_DEVICE_TABLE(of, mms114_dt_match);
> #endif
>
> static struct i2c_driver mms114_driver = {
> --
> 2.4.6
>

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/