Re: [PATCH] [v4] surface pro 3: Add support driver for Surface Pro 3 buttons
From: Darren Hart
Date: Thu Sep 03 2015 - 15:20:21 EST
On Tue, Sep 01, 2015 at 01:30:27PM -0400, Josh Boyer wrote:
> On Fri, Aug 28, 2015 at 1:56 PM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote:
> > On Wed, Aug 26, 2015 at 05:04:01AM -0700, Joe Perches wrote:
> >> On Wed, 2015-08-26 at 00:22 -0700, Darren Hart wrote:
> >> > On Tue, Aug 18, 2015 at 11:30:25PM +0800, Chen Yu wrote:
> >> > > Since Surface Pro 3 does not follow the specs of "Windows ACPI Design
> >> > > Guide for SoC Platform", code in drivers/input/misc/soc_array.c can
> >> > > not detect these buttons on it. According to bios implementation,
> >> > > Surface Pro 3 encapsulates these buttons in a device named "VGBI",
> >> > > with _HID "MSHW0028". When any of the buttons is pressed, a specify
> >> > > ACPI notification code for this button will be delivered to "VGBI". For
> >> > > example, if power button is pressed down, ACPI notification code of 0xc6
> >> > > will be sent by Notify(VGBI, 0xc6).
> >> 
> >> > Joe, you provided a lot of review, are you happy with this version?
> >> It looks fine.
> >> Thanks for picking the other little nits too Darren.
> > This is not queued for next.
> Not or now? If not, why not?
Sorry, typo :-)
It is queued for next, you'll find it in my "for-next" branch as well as in
Intel Open Source Technology Center
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/