Re: [RFC PATCH] mmc: block: Add new ioctl to send combo commands

From: Grant Grundler
Date: Thu Sep 03 2015 - 21:16:47 EST

[resending...keep forgetting to switch back to text-only in gmail]

On Thu, Sep 3, 2015 at 8:10 AM, Jon Hunter <jonathanh@xxxxxxxxxx> wrote:
>>> If alignment matters, then maybe swap the fields?
>>> Or declare num_of_cmds as u64 as well?
> Thanks. I did swap them in the updated version as this seems to make
> sense. However, I left num_of_cmds as an 8-bit value unless someone has
> a need for more than 256 commands ;-)

Awesome - thanks! I saw that in the new version you posted. LGTM.
You or Ulf can add "Reviewed by: Grant Grundler <grundler@xxxxxxxxxxxx"

(I just switched the "reply-from:" on you ;)

Ulf, anything else stand out?

I normally don't like to rush but we'd at least like confirmation that
struct mmc_ioc_combo_cmd is acceptable as is (since it's the main part
of the API).

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at