Re: [PATCH 5/9] drm: bridge/dw_hdmi: avoid being recursive in N calculation

From: Doug Anderson
Date: Fri Sep 04 2015 - 13:50:25 EST


Russell,

On Sat, Aug 8, 2015 at 9:10 AM, Russell King
<rmk+kernel@xxxxxxxxxxxxxxxx> wrote:
> There's no need to be recursive when computing the N value for the ACR
> packet - we can instead calculate the multiplier prior to our switch()
> based lookup, and multiply the N value appropriately afterwards.
>
> Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/dw_hdmi.c | 25 +++++++++----------------
> 1 file changed, 9 insertions(+), 16 deletions(-)

For what it's worth, I backported this change into my local 3.14-based
tree and it worked for me. It also looks good to me.

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/