On 09/04/15 14:30, Stas Sergeev wrote:Yes, that's what I was saying lengthy.
05.09.2015 00:16, Stas Sergeev ÐÐÑÐÑ:
I agree. vm86() is a mess.Grr, I mean it was disabled by default instead of doing this,
My point is that its risky parts and useless funtionality
is _already_ known (even I can point to the particular code
parts than can simply be removed). As such, it simply had
to be re-visited and cleaned up to match at least 1 and 3
(and then maybe 5). This wasn't done, and the knob was
introduced _instead_ of doing this.
and the knob was only proposed, not added.
You can't just pull vm86 out of the kernel anyway. dosemu is a userspace application that depends on it, so pulling this feature out would be a big fat regression, period.
I would personally rather not hear about how "it's a legacy program so its userbase is shrinking" used as any sort of excuse to ignore the fact that we shouldn't break userspace.
I can even say as a user that vm86 is important to me.
By all means, cleaning up vm86 is a good idea. But removing it or fencing it off with a strong deprecation doesn't sound like the right idea.