Re: [PATCH 6/9] drm: bridge/dw_hdmi: adjust pixel clock values in N calculation

From: Russell King - ARM Linux
Date: Sat Sep 05 2015 - 04:31:54 EST


On Fri, Sep 04, 2015 at 07:03:11PM -0700, Doug Anderson wrote:
> AKA: just replace your entire "compute_n" function with:
>
> return (128 * freq) / 1000;
>
> ...and it's 100% simpler _and_ gets you a (marginally) better rate
> (assuming you really have 22.175000). If it was just about a
> 32000.222 vs 32000 I'd not be saying anything right now. It's about
> adding complexity.

No. It doesn't work for all cases. Do the calculations for every
sample rate in those tables in the HDMI spec, and you'll find out
why.

--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/