Re: [PATCH] net/core/sysctl_net_core.c unused variable

From: Nick Warne
Date: Sun Sep 06 2015 - 11:17:07 EST

On 06/09/15 15:52, Joe Perches wrote:
On Sun, 2015-09-06 at 15:13 +0100, Nick Warne wrote:
gcc version 4.8.2 (GCC) warns that 'static int one = 1;' is declared but
not used in file net/core/sysctl_net_core.c.

Only when CONFIG_NET isn't set.


Peculiar indeed.

Reading the file, that is
the case. Attached is a patch to remove it.

$ git grep -w -n one net/core/sysctl_net_core.c
net/core/sysctl_net_core.c:26:static int one = 1;
net/core/sysctl_net_core.c:332: .extra2 = &one

Signed-off-by: Nick Warne <nick@xxxxxxxxxxx>

Please use grep to augment reading.

grep -w -n one net/core/sysctl_net_core.c
26:static int one = 1;


I just don't have the &one.

I am confused now.

Gosh that takes me back... or is it forward? That's the trouble with
time travel, you never can tell."
-- Doctor Who "Androids of Tara"
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at