Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection
From: Bob Liu
Date: Mon Sep 07 2015 - 02:08:01 EST
On 09/04/2015 09:51 PM, Julien Grall wrote:
> Hi Roger,
> On 04/09/15 11:08, Roger Pau Monne wrote:
>> Request allocation has been moved to connect_ring, which is called every
>> time blkback connects to the frontend (this can happen multiple times during
>> a blkback instance life cycle). On the other hand, request freeing has not
>> been moved, so it's only called when destroying the backend instance. Due to
>> this mismatch, blkback can allocate the request pool multiple times, without
>> freeing it.
>> In order to fix it, move the freeing of requests to xen_blkif_disconnect to
>> restore the symmetry between request allocation and freeing.
>> Reported-by: Julien Grall <julien.grall@xxxxxxxxxx>
>> Signed-off-by: Roger Pau MonnÃ <roger.pau@xxxxxxxxxx>
>> Cc: Julien Grall <julien.grall@xxxxxxxxxx>
>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>> Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
>> Cc: David Vrabel <david.vrabel@xxxxxxxxxx>
>> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
> The patch is fixing my problem when using UEFI in the guest. Thank you!
Could you please explain the problem you met a bit more?
So that I can know back port this patch if met similar issue.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/