Re: [PATCH v2] QEMU fw_cfg DMA interface documentation

From: Laszlo Ersek
Date: Mon Sep 07 2015 - 07:25:29 EST


On 09/07/15 13:08, Gerd Hoffmann wrote:
> Hi,
>
>> It's just simplicity. If you want to read a few times from the same
>> field (like in ACPI tables, read the data size and then the data), you
>> need a way to enable and disable the selector and manage the current
>> offset for that entry. This is already provided with the "old"
>> interface.
>
> Could be handled with a 'select' control bit. Only when set select
> entry and reset offset to zero.
>
> Also: would it make sense to allow an *array* of FWCfgDmaAccess structs?
> With a 'more' bit in control we could indicate that there are more
> entries. I'm not sure firmware would actually use that though ...

Seems far-fetched.

Thanks
Laszlo

> cheers,
> Gerd
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/