Re: [PATCH v8 2/2] ARM: imx: support suspend states on imx7D
From: Shawn Guo
Date: Mon Sep 07 2015 - 11:11:34 EST
On Fri, Jul 31, 2015 at 04:33:59PM -0500, Shenwei Wang wrote:
> IMX7D contains a new version of GPC IP block (GPCv2). It has two
> major functions: power management and wakeup source management.
> GPCv2 provides low power mode control for Cortex-A7 and Cortex-M4
> domains. And it can support WAIT, STOP, and DSM(Deep Sleep Mode) modes.
> After configuring the GPCv2 module, the platform can enter into a
> selected mode either automatically triggered by ARM WFI instruction or
> manually by software. The system will exit the low power states
> by the predefined wakeup sources which are managed by the gpcv2
> irqchip driver.
> This patch adds a new suspend driver to manage the power states on IMX7D.
> It currently supports "SUSPEND_STANDBY" and "SUSPEND_MEM" states.
> Signed-off-by: Shenwei Wang <shenwei.wang@xxxxxxxxxxxxx>
> Signed-off-by: Anson Huang <b20788@xxxxxxxxxxxxx>
Please stop sending patches to my Linaro mailbox, and use
shawnguo@xxxxxxxxxx instead. You should already get that if you ever
run ./scripts/get_maintainer.pl on the patch. Also please always copy
kernel@xxxxxxxxxxxxxx for i.MX platform patches like this.
> arch/arm/mach-imx/Kconfig | 1 +
> arch/arm/mach-imx/Makefile | 2 +
> arch/arm/mach-imx/common.h | 4 +
> arch/arm/mach-imx/pm-imx7.c | 917 +++++++++++++++++++++++++++++++++++++++
> arch/arm/mach-imx/suspend-imx7.S | 529 ++++++++++++++++++++++
> 5 files changed, 1453 insertions(+)
1453 lines addition to kernel only for i.MX7D suspend support. Yes,
this is the way we support suspend on i.MX6, but that's enough, and
we have to stop this somewhere. I would ask you to take Sudeep's
comment and adopt PSCI for i.MX7D power management.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/