Re: [RFC PATCH 10/14] ring_buffer: Fix more races when terminating the producer in the benchmark

From: Oleg Nesterov
Date: Mon Sep 07 2015 - 13:52:09 EST


Sorry, I didn't read these emails, and I never looked at this code...
Can't understand what are you talking about but a minor nit anyway ;)

On 09/04, Petr Mladek wrote:
>
> + __set_current_state(TASK_RUNNING);
> if (!kthread_should_stop())
> wait_to_die();

I bet this wait_to_die() can die, consumer/producer can simply exit.

Just you need get_task_struct() after kthread_create(), and put_task_struct()
after kthread_stop().

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/