Re: [PATCH v2] stmmac: fix check for phydev being open

From: Alexey Brodkin
Date: Mon Sep 07 2015 - 17:08:31 EST

Hi Sergei,

On Mon, 2015-09-07 at 23:53 +-0300, Sergei Shtylyov wrote:
+AD4- On 09/07/2015 11:50 PM, Alexey Brodkin wrote:
+AD4- +AD4- Current implementation via IS+AF8-ERR(phydev) may make no sense because
+AD4- +AD4- of+AF8-phy+AF8-attach() returns NULL on failure instead of error value.
+AD4- +AD4-
+AD4- +AD4- Still for checking result of phy+AF8-connect() IS+AF8-ERR() is useful.
+AD4- +AD4-
+AD4- +AD4- To address both situations we use combined IS+AF8-ERR+AF8-OR+AF8-NULL() check.
+AD4- +AD4-
+AD4- +AD4- Cc: Giuseppe Cavallaro
+AD4- +AD4- Cc:
+AD4- +AD4- Cc:
+AD4- +AD4- Cc: David Miller
+AD4- +AD4- Cc: Sergei Shtylyov
+AD4- +AD4- Signed-off-by: Alexey Brodkin
+AD4- +AD4- ---
+AD4- +AD4-
+AD4- +AD4- Changes compared to v1:
+AD4- +AD4- +ACo- Use IS+AF8-ERR+AF8-OR+AF8-NULL() instead of discrete checks for null and err
+AD4- +AD4-
+AD4- +AD4- drivers/net/ethernet/stmicro/stmmac/stmmac+AF8-main.c +AHw- 2 +--
+AD4- +AD4- 1 file changed, 1 insertion(+-), 1 deletion(-)
+AD4- +AD4-
+AD4- +AD4- diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac+AF8-main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac+AF8-main.c
+AD4- +AD4- index 864b476..7985d8a 100644
+AD4- +AD4- --- a/drivers/net/ethernet/stmicro/stmmac/stmmac+AF8-main.c
+AD4- +AD4- +-+-+- b/drivers/net/ethernet/stmicro/stmmac/stmmac+AF8-main.c
+AD4- +AD4- +AEAAQA- -837,7 +-837,7 +AEAAQA- static int stmmac+AF8-init+AF8-phy(struct net+AF8-device +ACo-dev)
+AD4- +AD4- interface)+ADs-
+AD4- +AD4- +AH0-
+AD4- +AD4-
+AD4- +AD4- - if (IS+AF8-ERR(phydev)) +AHs-
+AD4- +AD4- +- if (IS+AF8-ERR+AF8-OR+AF8-NULL(phydev)) +AHs-
+AD4- +AD4- pr+AF8-err(+ACIAJQ-s: Could not attach to PHY+AFw-n+ACI-, dev-+AD4-name)+ADs-
+AD4- +AD4- return PTR+AF8-ERR(phydev)+ADs-
+AD4- Hm, in case of phydev +AD0APQ- NULL, you're going to return 0 here... is that
+AD4- what you want?

Ah, right.

So then the question would be what's a proper error code for +ACE-phydev:

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at