Re: [PATCH V2 1/9] cpufreq: Use __func__ to print function's name
From: Rafael J. Wysocki
Date: Mon Sep 07 2015 - 19:15:08 EST
On Monday, July 27, 2015 05:58:06 PM Viresh Kumar wrote:
> Its better to use __func__ to print functions name instead of writing
> the name in the print statement. This also has the advantage that a
> change in function's name doesn't force us to change the print message
> as well.
> Reviewed-by: Preeti U Murthy <preeti@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
OK, this is simple enough. Applied, thanks!
> drivers/cpufreq/cpufreq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 46251e8d30f2..f620055279f3 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -2074,8 +2074,7 @@ static int __cpufreq_governor(struct cpufreq_policy *policy,
> if (!try_module_get(policy->governor->owner))
> return -EINVAL;
> - pr_debug("__cpufreq_governor for CPU %u, event %u\n",
> - policy->cpu, event);
> + pr_debug("%s: for CPU %u, event %u\n", __func__, policy->cpu, event);
> if ((policy->governor_enabled && event == CPUFREQ_GOV_START)
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/