Re: [PATCH v2 1/6] selftests: rename jump label to static_keys

[Michael Ellerman]

On Mon, 2015-09-07 at 22:04 +0800, Bamvor Jian Zhang wrote:
> commit "2bf9e0a locking/static_keys: Provide a selftest" rename
                                                                 ^
								 d
> jump_label directory to static_keys.

... "and failed to update the Makefile, causing the selftests build to fail.
This commit fixes it by updating the Makefile with the new name and also moves
the entry into the correct position to keep the list alphabetically sorted."

Also the proper syntax for quoting a commit is:

Commit 2bf9e0ab08c6 ("locking/static_keys: Provide a selftest")

And ideally you also include a line saying:

Fixes: 2bf9e0ab08c6 ("locking/static_keys: Provide a selftest")

> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@xxxxxxxxxx>
> ---
>  tools/testing/selftests/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index ac40ec9..8922c21 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -17,12 +17,12 @@ TARGETS += powerpc
>  TARGETS += ptrace
>  TARGETS += seccomp
>  TARGETS += size
> +TARGETS += static_keys
>  TARGETS += sysctl
>  ifneq (1, $(quicktest))
>  TARGETS += timers
>  endif
>  TARGETS += user
> -TARGETS += jumplabel
>  TARGETS += vm
>  TARGETS += x86
>  TARGETS += zram


Otherwise:

Acked-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>

cheers





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/