Re: [PATCH v4 2/5] irqchip, gicv3: Workaround for Cavium ThunderX erratum 23154

[Suzuki K. Poulose]

On 08/09/15 10:00, Catalin Marinas wrote:
> On Mon, Sep 07, 2015 at 06:41:50PM +0100, Suzuki K. Poulose wrote:
> > On 07/09/15 18:15, Catalin Marinas wrote:
> > > On Mon, Sep 07, 2015 at 05:54:06PM +0100, Suzuki K. Poulose wrote:
> > > > On 14/08/15 19:28, Robert Richter wrote:
> > > > > +static void gicv3_enable_quirks(void)
> > > > > +{
> > > > > +	if (cpus_have_cap(ARM64_WORKAROUND_CAVIUM_23154))
> > > > > +		static_key_slow_inc(&is_cavium_thunderx);
> > > >
> > > > May be you could use the enable() method added to struct arm64_cpu_capability
> > > > here to perform the above operation, added by James :
> > > >
> > > > commit 1c0763037f1e1caef739e36e09c6d41ed7b61b2d
> > > > Author: James Morse <james.morse@xxxxxxx>
> > > > Date:   Tue Jul 21 13:23:28 2015 +0100
> > > >
> > > >      arm64: kernel: Add cpufeature 'enable' callback
> > >
> > > I thought about this as well when looking at the patch but decided it's
> > > better as it is. The "enable" method is meant to enable per-CPU features
> > > (or workarounds) but here it is about GICv3, so we don't want to enable
> > > for every CPU.
> >
> > Right. I have been playing with a series where the checks are delayed until
> > all CPUs are brought up.
>
> Unrelated to the GIC workaround, delaying the enable feature until the
> CPUs are brought up is not always be feasible.

Right. But then, enabling a feature(and applying the alternatives) based on
a single CPU may not be safe, always, like PAN. If one of the boot time CPU
doesn't have it, then we are in trouble (even though we WARN about it from
SANITY check)

> At some point we may
> implement support to defer the CPU on to user space (I already have a
> patch that does this when no DT enable-method is specified, but I won't
> publish it before Qualcomm fixes its firmware ;)). But we may have other
> reasons to start with CPUs hot-unplugged by default and turn them on
> later.

We have SANITY check infrastructure that WARNs in such cases, if the features
don't match.  But still, wouldn't it be better to enable a feature
only if all the boot-time enabled CPUs have it ? (Errata is an exception though,
which only depends on whether one of the CPU needs it).

Thanks
Suzuki

>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/