Re: [PATCH v3] zram: fix possible use after free in zcomp_create()

[Minchan Kim]

On Tue, Sep 08, 2015 at 10:39:28AM +0100, Luis Henriques wrote:
> zcomp_create() verifies the success of zcomp_strm_{multi,siggle}_create()
> through comp->stream, which can potentially be pointing to memory that was
> freed if these functions returned an error.
> 
> While at it, replace a 'ERR_PTR(-ENOMEM)' by a more generic
> 'ERR_PTR(error)' as in the future zcomp_strm_{multi,siggle}_create() could
> return other error codes.  Function documentation updated accordingly.
> 
> Fixes: beca3ec71fe5 ("zram: add multi stream functionality")
> Cc: stable@xxxxxxxxxxxxxxx
> Cc: Sergey Senozhatsky <sergey.senozhatsky.work@xxxxxxxxx>
> Cc: Minchan Kim <minchan@xxxxxxxxxx>
> Signed-off-by: Luis Henriques <luis.henriques@xxxxxxxxxxxxx>
Acked-by: Minchan Kim <minchan@xxxxxxxxxx>

Thanks for the fix!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/