Re: similar files: fusbh200-hcd.c and fotg210-hcd.c

From: Felipe Balbi
Date: Tue Sep 08 2015 - 11:53:10 EST


On Mon, Sep 07, 2015 at 04:47:45PM +0200, Peter Senna Tschudin wrote:
> I executed a clone detection tool* on drivers source code and I found
> that the files
>
> drivers/usb/host/fusbh200-hcd.c
>
> and
>
> drivers/usb/host/fotg210-hcd.c
>
> are very similar. The main difference between the two files are
> replacing the string 'USBH20' by 'OTG21' and some white space fixes.
> Some changes are being applied to only one of the files, such as the
> commit f848a88d223cafa43cb318839a1171b498cf5ec8 that changes
> fotg210-hcd.c but not fusbh200-hcd.c.
>
> Should these files be consolidated? And if so how?

if you can find an easy way, that would be a very, very welcome patch.

--
balbi

Attachment: signature.asc
Description: Digital signature