Re: [PATCH v2] of_pci_irq: Silence bogus "of_irq_parse_pci() failed ..." messages.

[David Daney]

On 09/09/2015 10:44 AM, Frank Rowand wrote:
> Second attempt at this reply.  The first reply was mangled.
>
> On 9/8/2015 11:28 AM, David Daney wrote:
> > From: David Daney <david.daney@xxxxxxxxxx>
> >
> > It is perfectly legitimate for a PCI device to have an
> > PCI_INTERRUPT_PIN value of zero.  This happens if the device doesn't
> > use interrupts, or on PCIe devices, where only MSI/MSI-X are
> > supported.
> >
> > Silence the annoying "of_irq_parse_pci() failed with rc=-19" error
> > messages by moving the printing code into of_irq_parse_pci(), and only
> > emitting the message for cases where PCI_INTERRUPT_PIN == 0 is not the
> > cause for an early exit.
> >
> > Signed-off-by: David Daney <david.daney@xxxxxxxxxx>
> > ---
> > Changes in v2: Move the print function in to of_irq_parse_pci() at a
> > common error exit point (as suggested by Frank Rowand).
[...]
> > @@ -87,6 +89,9 @@ int of_irq_parse_pci(const struct pci_dev *pdev, struct of_phandle_args *out_irq
> >   	laddr[0] = cpu_to_be32((pdev->bus->number << 16) | (pdev->devfn << 8));
> >   	laddr[1] = laddr[2] = cpu_to_be32(0);
>
> >   	return of_irq_parse_raw(laddr, out_irq);
>
> should be:
>
>          rc = of_irq_parse_raw(laddr, out_irq);
>          if (rc)
>                  goto err;
>          return 0;

You are right.  I will send v3.

Thanks,
David Daney

> > +err:
> > +	dev_err(&pdev->dev, "of_irq_parse_pci() failed with rc=%d\n", rc);
> > +	return rc;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/