RE: [PATCH 1/3] perf probe: Free perf probe event in cleanup_perf_probe_events()

[åæéå / HIRAMATUïMASAMI]

Hi Namhyung,

>From: Namhyung Kim [mailto:namhyung@xxxxxxxxx] On Behalf Of Namhyung Kim
>Sent: Thursday, September 10, 2015 11:27 AM
>To: Arnaldo Carvalho de Melo
>Cc: Ingo Molnar; Peter Zijlstra; Jiri Olsa; LKML; Wang Nan; åæéå / HIRAMATUïMASAMI
>Subject: [PATCH 1/3] perf probe: Free perf probe event in cleanup_perf_probe_events()
>
>The cleanup_perf_probe_events() frees all resources related to a perf
>probe event.  However it only freed resources in trace probe events, not
>perf probe events.  So call clear_perf_probe_event() too.

This looks good to me :)

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>

Thanks!


>
>Cc: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
>Reported-by: Wang Nan <wangnan0@xxxxxxxxxx>
>Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
>---
> tools/perf/util/probe-event.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
>index 5964eccbe94d..3d7d60cc6f16 100644
>--- a/tools/perf/util/probe-event.c
>+++ b/tools/perf/util/probe-event.c
>@@ -2792,6 +2792,7 @@ void cleanup_perf_probe_events(struct perf_probe_event *pevs, int npevs)
> 			clear_probe_trace_event(&pevs[i].tevs[j]);
> 		zfree(&pevs[i].tevs);
> 		pevs[i].ntevs = 0;
>+		clear_perf_probe_event(&pevs[i]);
> 	}
>
> 	exit_symbol_maps();
>--
>2.5.0