Re: [PATCH 2/3] serial: samsung: remove unneded 'ignore_char' label

From: Robert Baldyga
Date: Thu Sep 10 2015 - 06:30:28 EST


On 09/10/2015 02:27 AM, Krzysztof Kozlowski wrote:
> On 08.09.2015 18:38, Robert Baldyga wrote:
>> This label does nothing special and we don't need to have it anymore.
>>
>> Signed-off-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx>
>> ---
>> drivers/tty/serial/samsung.c | 7 ++-----
>> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> Label does nothing but it has a meaning. It serves as a comment - ignore
> the character. So maybe:
>
> - goto ignore_char;
> + continue; /* Ignore character */
>
> What do you think?

Look good to me.

Thanks,
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/