RE: [PATCH 04/13] perf env: Introduce read_cpu_topology_map() method

[Liang, Kan]

> Em Thu, Sep 10, 2015 at 08:00:54PM +0000, Liang, Kan escreveu:
> > > Em Wed, Sep 09, 2015 at 09:41:18PM +0000, Liang, Kan escreveu:
> > > > > -	for (i = 0; i < tp->cpu_nr; i++) {
> > > > > -		ret = do_write(fd, &tp->core_id[i], sizeof(int));
> > > > > +	perf_env__read_cpu_topology_map(&perf_env);
> > > > > +
> 
> > > > I think we need to handle error here.
> 
> > > Ok, adding a test, updated patch below. While doing that, noticed
> > > that the in the thread_sib case the "ret = do_something()" doesn't
> > > makes the whole function fail, will fix later.
> 
> > Except patch 11 & 13 (for reverting), the rest of patches are good to me.
> 
> Ok, so, to take it more formally, can I turn this "good to me" as justification
> for adding "Acked-by: Kan Liang", to those patches?

Yes.

> 
> Please take a look at the other patches in the perf/env branch, I did it while
> trying to figure it out if the reverts should be kept.
>
OK

Thanks,
Kan
 
> - Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/