Re: [PATCH net] bridge: fix igmpv3 / mldv2 report parsing

[David Miller]

From: Linus Lüssing <linus.luessing@xxxxxxxxx>
Date: Fri, 11 Sep 2015 18:39:48 +0200

> With the newly introduced helper functions the skb pulling is hidden in
> the checksumming function - and undone before returning to the caller.
> 
> The IGMPv3 and MLDv2 report parsing functions in the bridge still
> assumed that the skb is pointing to the beginning of the IGMP/MLD
> message while it is now kept at the beginning of the IPv4/6 header,
> breaking the message parsing and creating packet loss.
> 
> Fixing this by taking the offset between IP and IGMP/MLD header into
> account, too.
> 
> Fixes: 9afd85c9e455 ("net: Export IGMP/MLD message validation code")
> Reported-by: Tobias Powalowski <tobias.powalowski@xxxxxxxxxxxxxx>
> Tested-by: Tobias Powalowski <tobias.powalowski@xxxxxxxxxxxxxx>
> Signed-off-by: Linus Lüssing <linus.luessing@xxxxxxxxx>

There were many serious regressions introduced by that commit, I'm
extremely disappointed.

Patch applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/