Re: [PATCH v3 2/2] lib/test-string_helpers.c: add string_get_size() tests

[Rasmus Villemoes]

On Mon, Sep 14 2015, Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> wrote:

> +static __init void test_string_get_size_one(u64 size, u64 blk_size,
> +					    const enum string_size_units units,
> +					    const char *exp_result)
> +{
> +	char buf[256];
> +
> +	string_get_size(size, blk_size, units, buf, sizeof(buf));
> +	if (!strncmp(buf, exp_result, min(sizeof(buf), strlen(exp_result))))
> +		return;

Nits: It probably makes sense to also test that string_get_size
'\0'-terminates the buffer, so I'd spell this

  if (!memcmp(buf, exp_result, min(sizeof(buf), strlen(exp_result)+1)))

With a generous stack buffer, that min() will always evaluate to the
strlen(exp_result)+1. On that note: Maybe 256 is a bit excessive. I
don't think this will run very deep in the kernel stack, but the code might
get copy-pasted somewhere else. 16 should be plenty.

> +	pr_warn("Test 'test_string_get_size_one' failed!\n");
> +	pr_warn("string_get_size(size = %llu, blk_size = %llu, units = %d\n",
> +		size, blk_size, units);

[There's probably no pretty way of getting from units to a text
representation, but it's slightly annoying to have to check the source
for the enum definition to figure out what units=0 or units=1 means.]

> +	pr_warn("expected: %s, got %s\n", exp_result, buf);

In case we failed to '\0'-terminate buf, we might want to print it with
"%.*s", (int)sizeof(buf), buf. But maybe I'm just overly paranoid.

Rasmus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/