Re: [PATCH v4 2/7] power: bq27x00_battery: Renaming for consistency

[Laurentiu Palcu]

On Mon, Sep 14, 2015 at 04:26:08PM -0500, Andrew F. Davis wrote:
> Rename functions that are used by multiple devices. New devices
> have been added and the function names and driver name are no longer
> general enough for the functionality they provide.
> 
> Signed-off-by: Andrew F. Davis <afd@xxxxxx>
> ---
>  MAINTAINERS                                        |   4 +-
>  arch/arm/configs/omap2plus_defconfig               |   2 +-
>  arch/unicore32/Kconfig                             |   2 +-
>  drivers/power/Kconfig                              |  22 +-
>  drivers/power/Makefile                             |   2 +-
>  .../power/{bq27x00_battery.c => bq27xxx_battery.c} | 333 +++++++++++----------

1000 chips! That's how many potential chips is this driver supposed to
support, after the rename, with little or no modifications. Is it even
possible to guarantee that all future chips, starting with 'bq27' in
their naming scheme, are register compatible?

Call me conservative, but when I see driver names/renames containing
wildcards, I get chills down my spine. I can probably get over single
digit wildcards but 3 digit wildcards is a little too much. :)

I can't help but wonder what will one have to do if one single newly
released bq27xxx chip is completely different... :/

laurentiu


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/