Re: [PATCH 1/1] signals: kill block_all_signals() and unblock_all_signals()

[Dave Airlie]

On 16 September 2015 at 02:41, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> ping ;)
>
> Andrew, should I re-send this patch? It was acked by Daniel and Dave
> doesn't object.
>
> Dave, I'll appreciate it if you ack it explicitly.
>
>
> On 08/27, Oleg Nesterov wrote:
>>
>> It is hardly possible to enumerate all problems with block_all_signals()
>> and unblock_all_signals(). Just for example,
>>
>> 1. block_all_signals(SIGSTOP/etc) simply can't help if the caller is
>>    multithreaded. Another thread can dequeue the signal and force the
>>    group stop.
>>
>> 2. Even is the caller is single-threaded, it will "stop" anyway. It
>>    will not sleep, but it will spin in kernel space until SIGCONT or
>>    SIGKILL.
>>
>> And a lot more. In short, this interface doesn't work at all, at least
>> the last 10+ years.
>>
>> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Acked-by: Dave Airlie <airlied@xxxxxxxxxx>

Probably best to go via Andrew alright.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/