Re: [PATCH 3/3] EDAC, amd64_edac: Update copyright and documentation info

[Borislav Petkov]

On Wed, Sep 16, 2015 at 03:53:31PM -0500, Aravind Gopalakrishnan wrote:
> Extending the comments section to include the BKDG references
> for newer processors which this EDAC driver supports.
> 
> Updated the copyrights info and fixed a trivial typo while at it.
> 
> Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@xxxxxxx>
> ---
>  drivers/edac/amd64_edac.h | 30 ++++++++++++++++++++++++++++--
>  1 file changed, 28 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/amd64_edac.h b/drivers/edac/amd64_edac.h
> index 15c0eb4..1e34d07 100644
> --- a/drivers/edac/amd64_edac.h
> +++ b/drivers/edac/amd64_edac.h
> @@ -2,7 +2,7 @@
>   * AMD64 class Memory Controller kernel module
>   *
>   * Copyright (c) 2009 SoftwareBitMaker.
> - * Copyright (c) 2009 Advanced Micro Devices, Inc.
> + * Copyright (c) 2009-15 Advanced Micro Devices, Inc.
>   *
>   * This file may be distributed under the terms of the
>   * GNU General Public License.
> @@ -36,13 +36,18 @@
>   *	Changes/Fixes by Borislav Petkov <bp@xxxxxxxxx>:
>   *		- misc fixes and code cleanups
>   *
> + *	Changes by Aravind Gopalakrishnan <aravind.gopalakrishnan@xxxxxxx>
> + *		- Add support for-
> + *		   - Fam15h Models (30-3fh; 60-6fh)
> + *		   - Fam16h Models (00-0fh; 30-3fh)
> + *

Actually, we have git which can give you all the exact changelog
information you'd need. So instead of adding more to the header, simply
remove all changelog info from there. It is a thing from the past anyway.

>   * This module is based on the following documents
>   * (available from http://www.amd.com/):
>   *
>   *	Title:	BIOS and Kernel Developer's Guide for AMD Athlon 64 and AMD
>   *		Opteron Processors
>   *	AMD publication #: 26094
> - *`	Revision: 3.26
> + *	Revision: 3.26
>   *
>   *	Title:	BIOS and Kernel Developer's Guide for AMD NPT Family 0Fh
>   *		Processors
> @@ -56,6 +61,27 @@
>   *	Revision: 3.00
>   *	Issue Date: September 07, 2007
>   *
> + *	Title: BIOS and Kernel Developer's Guide (BKDG) for AMD Family 15h
> + *	       Models 30h-3Fh Processors
> + *	AMD publication #: 49125
> + *	Revision: 3.06
> + *	Issue Date: 2/12/2015 (latest release)
> + *	Link: http://support.amd.com/TechDocs/49125_15h_Models_30h-3Fh_BKDG.pdf
> + *
> + *	Title: BIOS and Kernel Developer's Guide (BKDG) for AMD Family 15h
> + *	       Models 60h-6Fh Processors
> + *	AMD publication #: 50742
> + *	Revision: 3.01
> + *	Issue Date: 7/23/2015 (latest release)
> + *	Link: http://support.amd.com/TechDocs/50742_15h_Models_60h-6Fh_BKDG.pdf
> + *
> + *	Title: BIOS and Kernel Developer's Guide (BKDG) for AMD Family 16h
> + *	       Models 00h-0Fh Processors
> + *	AMD publication #: 48751
> + *	Revision: 3.03
> + *	Issue Date: 2/23/2015 (latest release)
> + *	Link: http://support.amd.com/TechDocs/48751_16h_bkdg.pdf
> + *

You can add those to an amd64_edac section of Documentation/edac.txt.

I want to keep header files as clean as possible. Copyright updates are
fine but everything history-like and unrelated to functionality should
go somewhere else, if at all.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/