Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability and compatible

[Caesar Wang]

Hi Daniel,


å 2015å09æ17æ 17:11, Daniel Lezcano åé:
> Hi Caesar,
>
>
> On 09/17/2015 09:51 AM, Caesar Wang wrote:
> > Build the arm64 SoCs (e.g.: RK3368) on Rockchip platform,
> > There are some failure with build up on timer driver for rockchip.
> >
> > logs:
> > ...
> > drivers/clocksource/rockchip_timer.c:156:13: error: 'NO_IRQ' undeclared
>
> I think the NO_IRQ definition is missing for ARM64.

Yep, Maybe better to compatible if we don't use the 'NO_IRQ',

> > /tmp/ccdAnNy5.s:47: Error: missing immediate expression at  operand 1 --
> > `dsb`
> > ...
> >
> > The problem was different semantics of dsb on btw arm32 and arm64,
> > Here we can convert the dsb with insteading of dsb(sy).
>
> What happens to ARM32 then ?

The dsb() is ok for ARM32, the ARM32/64 are OK if we can convert the 
dsb() to dsb(sy).
I believe all drivers with 'dsb()' have same issue on ARM64 platform.

> > Meanwhile, I change a bit to make the code more readability for driver
> > when I check the code style.
> >
> > Signed-off-by: Caesar Wang <wxt@xxxxxxxxxxxxxx>


--
Thanks,
Caesar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/