Re: [PATCH 03/13] Move COMPAT_ATM_ADDPARTY to net/atm/svc.c

From: David Howells
Date: Thu Sep 17 2015 - 05:57:39 EST


Palmer Dabbelt <palmer@xxxxxxxxxxx> wrote:

> +#ifdef CONFIG_COMPAT
> +/* It actually takes struct sockaddr_atmsvc, not struct atm_iobuf */
> +#define COMPAT_ATM_ADDPARTY _IOW('a', ATMIOC_SPECIAL+4, struct compat_atm_iobuf)
> +#endif

I wonder if it would hurt to ditch the conditionals entirely. It only eats
cpp namespace, not C namespace so it won't affect the output if it is not used
because the code that uses it is compiled out.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/