Re: Regression by 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a guest")

From: Linus Walleij
Date: Thu Sep 17 2015 - 16:51:25 EST


On Wed, Sep 16, 2015 at 6:32 PM, Jisheng Zhang <jszhang@xxxxxxxxxxx> wrote:

> Hi Marc,
>
> Commit 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a
> guest") causes a regression on Marvell BG4CT SoC. In this SoC, there's only one
> GIC, the secondary irq controller is Synopsys DW iCtl:
> drivers/irqchip/irq-dw-apb-ictl.c
>
> So cascading_gic_irq() should return true on Marvell BG4CT SoC, but it returns
> false. The logic in cascading_gic_irq() doesn't take cascaded irq controller
> which is provided by non-gic controllers.
>
> bisect log is as following:

I bisected a GPIO IRQ problem on the ARM Juno reference design
down to the same commit today, haven't had time to test the
patch and going on travels, but I'm hoping it is solving itself now then.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/