Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability and compatible

[Caesar Wang]

Hi Daniel,

å 2015å09æ18æ 15:55, Daniel Lezcano åé:
> On 09/17/2015 12:19 PM, Caesar Wang wrote:
> > å 2015å09æ17æ 18:06, Daniel Lezcano åé:
> > > On 09/17/2015 11:28 AM, Caesar Wang wrote:
> > > > Hi Daniel,
> > > >
> > > >
> > > > å 2015å09æ17æ 17:11, Daniel Lezcano åé:
> > > > > Hi Caesar,
> > > > >
> > > > >
> > > > > On 09/17/2015 09:51 AM, Caesar Wang wrote:
> > > > > > Build the arm64 SoCs (e.g.: RK3368) on Rockchip platform,
> > > > > > There are some failure with build up on timer driver for rockchip.
> > > > > >
> > > > > > logs:
> > > > > > ...
> > > > > > drivers/clocksource/rockchip_timer.c:156:13: error: 'NO_IRQ'
> > > > > > undeclared
> > > > >
> > > > > I think the NO_IRQ definition is missing for ARM64.
> > > >
> > > > Yep, Maybe better to compatible if we don't use the 'NO_IRQ',
> > >
> > > Hmm, after digging into drivers/of/irq.c and kernel/irq/irqdomain.c
> > >
> > > when there is an error it returns zero. So NO_IRQ and -1 are not
> > > correct and on the other side zero can be a valid irq. That sounds a
> > > little bit fuzzy to me.
> >
> > I believe the 'NO_IRQ' is better select if 'NO_IRQ' is defined on ARM64
> > platform.
> >
> >      irq = irq_of_parse_and_map(np, 0);
> >
> >      if (irq  == NO_IRQ)
> > ...
> > Also, that's ok if we instead of the 'irq < 0'  or  '!irq' , right?
>
>
> Hi Caesar,
>
> so regarding Thomas and Russel answers, let's replace NO_IRQ by '!irq'.

Fixed, I will send the patch v1.

> Thanks.
>
>   -- Daniel

--
Thanks,
Caesar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/