Re: [PATCH v2 04/23] ARM: davinci/common: Convert edma driver to handle one eDMA instance per driver

[Peter Ujfalusi]

On 09/11/2015 03:27 PM, Peter Ujfalusi wrote:
> +	if (irq >= 0) {
> +		irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccint\n",

The '\n' should not be in the format string.

> +					  dev_name(dev));
> +		ret = devm_request_irq(dev, irq, dma_irq_handler, 0, irq_name,
> +				       cc);
> +		if (ret) {
> +			dev_err(dev, "CCINT (%d) failed --> %d\n", irq, ret);
> +			return ret;
>  		}
> +	}
>  
> -		for (i = 0; i < edma_cc[j]->num_channels; i++)
> -			map_dmach_queue(j, i, info[j]->default_queue);
> +	irq = platform_get_irq_byname(pdev, "edma3_ccerrint");
> +	if (irq < 0 && node)
> +		irq = irq_of_parse_and_map(node, 2);
> +
> +	if (irq >= 0) {
> +		irq_name = devm_kasprintf(dev, GFP_KERNEL,
> +					  "%s_ccerrint\n",

Same here.

> +					  dev_name(dev));
> +		ret = devm_request_irq(dev, irq, dma_ccerr_handler, 0, irq_name,
> +				       cc);
> +		if (ret) {
> +			dev_err(dev, "CCERRINT (%d) failed --> %d\n", irq, ret);
> +			return ret;
> +		}
> +	}

-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/