Re: [PATCH] usb: chipidea: udc: improve error handling on ep_queue and f_midi

[Felipe Balbi]

Hi,

On Fri, Sep 18, 2015 at 05:48:45PM +0100, eu@xxxxxxxxxxxxxxxxx wrote:
> From: "Felipe F. Tonello" <eu@xxxxxxxxxxxxxxxxx>
> 
> _ep_queue() didn't check for errors when using add_td_to_list()
> which can fail if dma_pool_alloc fails, thus causing a kernel
> panic when lastnode->ptr is NULL.
> 
> Also f_midi is not checking weather the is an error on usb_ep_queue
> request, ignoring potential problems, such as memory leaks.
> 
> Signed-off-by: Felipe F. Tonello <eu@xxxxxxxxxxxxxxxxx>
> ---
>  drivers/usb/chipidea/udc.c           | 26 +++++++++++++++++++-------
>  drivers/usb/gadget/function/f_midi.c | 11 +++++++++--

why are you patching f_midi.c in a chipidea patch ? Have a read at
Documentation/SubmittingPatches, Documentation/SubmitChecklist

-- 
balbi

Attachment: signature.asc
Description: Digital signature