Re: [PATCH] irq_remapping: move structs outside #ifdef

From: Thomas Gleixner
Date: Fri Sep 18 2015 - 14:44:22 EST




On Fri, 18 Sep 2015, Paolo Bonzini wrote:

> This is friendlier to clients of the code, who are going to prepare
> vcpu_data structs unconditionally, even if CONFIG_IRQ_REMAP is not
> defined.
>
> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>


Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

> ---
> Please ack, I'd like to include it in the 4.4 pull request.
>
> arch/x86/include/asm/irq_remapping.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/include/asm/irq_remapping.h b/arch/x86/include/asm/irq_remapping.h
> index 046c7fb1ca43..a210eba2727c 100644
> --- a/arch/x86/include/asm/irq_remapping.h
> +++ b/arch/x86/include/asm/irq_remapping.h
> @@ -33,6 +33,11 @@ enum irq_remap_cap {
> IRQ_POSTING_CAP = 0,
> };
>
> +struct vcpu_data {
> + u64 pi_desc_addr; /* Physical address of PI Descriptor */
> + u32 vector; /* Guest vector of the interrupt */
> +};
> +
> #ifdef CONFIG_IRQ_REMAP
>
> extern bool irq_remapping_cap(enum irq_remap_cap cap);
> @@ -58,11 +63,6 @@ static inline struct irq_domain *arch_get_ir_parent_domain(void)
> return x86_vector_domain;
> }
>
> -struct vcpu_data {
> - u64 pi_desc_addr; /* Physical address of PI Descriptor */
> - u32 vector; /* Guest vector of the interrupt */
> -};
> -
> #else /* CONFIG_IRQ_REMAP */
>
> static inline bool irq_remapping_cap(enum irq_remap_cap cap) { return 0; }
> --
> 1.8.3.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/