Re: [PATCH v5 07/23] regulator: core: Remove regulator_list

[Tomeu Vizoso]

On 19 September 2015 at 17:01, Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Thu, Sep 17, 2015 at 02:57:01PM +0200, Tomeu Vizoso wrote:
>> As we are already registering a device with regulator_class for each
>> regulator device, regulator_list is redundant and can be replaced with
>> calls to class_find_device() and class_for_each_device().
>
> This appears to leak references to the struct devices returned by
> class_find_device() - it takes a reference before it returns so any
> device found using class_find_device() needs to be released with
> put_device() and I don't see any new put_device() calls in here.

You are right, I have merged the subsequent patch into this one so no
refs are leaked in between.

Thanks,

Tomeu

>> Changes in v5: None
>> Changes in v4: None
>> Changes in v3: None
>> Changes in v2: None
>
> This is not the case at all, this patch was newly added.  If you want
> to include changelogs like this in the patch description try to ensure
> that they bear some relationship to reality, if they don't they are
> actively harmful as they are likely to mislead or annoy the reader.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/